linux-kernel - Re: [Stable-review] [36/55] [PARISC] slub: fix panic with DISCONTIGMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 May 2011 00:17:22 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Rientjes <rientjes@...gle.com>
Cc:	James Bottomley <James.Bottomley@...e.de>,
	Michael Schmitz <schmitzmic@...glemail.com>,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	Pekka Enberg <penberg@...nel.org>, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, stable-review@...nel.org,
	alan@...rguk.ukuu.org.uk, Greg KH <gregkh@...e.de>
Subject: Re: [Stable-review] [36/55] [PARISC] slub: fix panic with
 DISCONTIGMEM

On Tue, May 03, 2011 at 03:46:13PM -0700, David Rientjes wrote:
[...]
> SLUB relies heavily on N_NORMAL_MEMORY, so these two patches fix that 
> allocator but the problem is actually not just isolated to that subsystem; 
> it fixes an issue with anything that uses N_NORMAL_MEMORY.
> 
> The former patch sets the nodes correctly for parisc and Michael's patch 
> sets the nodes correctly for m68k, so it's the same fix for two different 
> previously-broken architectures.

So if I understand you correctly, the Kconfig condition for SLUB is
now wrong - only architectures that use DISCONTIGMEM's fake-NUMA and
don't set the node states to N_NORMAL_MEMORY will break it.  And
there's no good way to test for that in Kconfig.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/