linux-kernel - Re: [Stable-review] [36/55] [PARISC] slub: fix panic with DISCONTIGMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304464845.14015.13.camel@mulgrave.site>
Date:	Tue, 03 May 2011 18:20:45 -0500
From:	James Bottomley <James.Bottomley@...e.de>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	David Rientjes <rientjes@...gle.com>,
	Michael Schmitz <schmitzmic@...glemail.com>,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	Pekka Enberg <penberg@...nel.org>, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, stable-review@...nel.org,
	alan@...rguk.ukuu.org.uk, Greg KH <gregkh@...e.de>
Subject: Re: [Stable-review] [36/55] [PARISC] slub: fix panic with
 DISCONTIGMEM

On Wed, 2011-05-04 at 00:17 +0100, Ben Hutchings wrote:
> On Tue, May 03, 2011 at 03:46:13PM -0700, David Rientjes wrote:
> [...]
> > SLUB relies heavily on N_NORMAL_MEMORY, so these two patches fix that 
> > allocator but the problem is actually not just isolated to that subsystem; 
> > it fixes an issue with anything that uses N_NORMAL_MEMORY.
> > 
> > The former patch sets the nodes correctly for parisc and Michael's patch 
> > sets the nodes correctly for m68k, so it's the same fix for two different 
> > previously-broken architectures.
> 
> So if I understand you correctly, the Kconfig condition for SLUB is
> now wrong - only architectures that use DISCONTIGMEM's fake-NUMA and
> don't set the node states to N_NORMAL_MEMORY will break it.

No, that's not correct; parisc does all of that and still oopses in SLUB
on range > 0 allocations.

I'm not sure why m68k works ... as far as I can tell, the page_to_nid()
issue should trip them as well.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/