linux-kernel - Re: [PATCH 1/6] writeback: pass writeback_control down to move_expired

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110504111310.GB5191@localhost>
Date:	Wed, 4 May 2011 19:13:10 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>,
	Mel Gorman <mel@...ux.vnet.ibm.com>,
	Mel Gorman <mel@....ul.ie>, Dave Chinner <david@...morbit.com>,
	Itaru Kitayama <kitayama@...bb4u.ne.jp>,
	Minchan Kim <minchan.kim@...il.com>,
	Linux Memory Management List <linux-mm@...ck.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/6] writeback: pass writeback_control down to
 move_expired_inodes()

On Wed, May 04, 2011 at 07:04:32PM +0800, Christoph Hellwig wrote:
> On Wed, Apr 20, 2011 at 04:03:37PM +0800, Wu Fengguang wrote:
> > No behavior change. This will add debug visibility to the code, for
> > example, to dump the wbc contents when kprobing queue_io().
> 
> I don't think it's a good idea.  The writeback_control should move
> back to just controlling per-inode writeback and not be passed to
> more routines dealing with high-level writeback.

Good point. I can do without this patch.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/