linux-kernel - Re: [PATCH 2/6] writeback: introduce writeback_control.inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110504111647.GA19261@infradead.org>
Date:	Wed, 4 May 2011 07:16:47 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kara <jack@...e.cz>, Mel Gorman <mel@...ux.vnet.ibm.com>,
	Mel Gorman <mel@....ul.ie>, Dave Chinner <david@...morbit.com>,
	Itaru Kitayama <kitayama@...bb4u.ne.jp>,
	Minchan Kim <minchan.kim@...il.com>,
	Linux Memory Management List <linux-mm@...ck.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] writeback: introduce writeback_control.inodes_cleaned

On Wed, May 04, 2011 at 07:11:30PM +0800, Wu Fengguang wrote:
> On Wed, May 04, 2011 at 07:05:00PM +0800, Christoph Hellwig wrote:
> > Same here - this has nothing to do with actual page writeback and really
> > should stay internal to fs/fs-writeback.c
> 
> OK, I'll check how to constrain writeback_control to the minimal scope.

The basic idea would be to pass the struct wb_writeback_work all the
way down to writeback_sb_inodes, and initialize the struct writeback_control
there.  This requires adding a few more fields like more_io and
older_than_this to struct wb_writeback_work, and redoing a lot of the
tracing, but it immediately clean things up, e.g. suddently
wbc.nr_to_write vs work->nr_pages starts to make sense, and instead
of saving and restoring pages_skipped in writeback_sb_inodes it can
always start with a clean zero value.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/