linux-kernel - Re: [PATCH] m68k: Merge mmu and non-mmu versions of sys_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 May 2011 08:24:33 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"Linux/m68k" <linux-m68k@...ts.linux-m68k.org>,
	Greg Ungerer <gerg@...inux.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	uClinux list <uclinux-dev@...inux.org>
Subject: Re: [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table

On Wednesday 04 May 2011, Geert Uytterhoeven wrote:
> Impact for nommu:
>   - Store table in .rodata instead of .text,
>   - Let kernel/sys_ni.c handle the stubbing of MMU-only syscalls,
>   - Implement sys_mremap and sys_nfsservct,
>   - Remove unused padding at the end of the table.
> 
> Impact for mmu:
>   - Store table in .rodata instead of .data.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

What happened to the mmap syscall? IIRC, nommu is pointing to
a different symbol (sys_mmap_pgoff/sys_mmap2).

Did you check the macros in unistd to see if they match the
actual table? I guess it would be a good time to comment out
the ones that are not implemented in either of the two ABIs.

Otherwise, this patch looks good to me.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/