linux-kernel - Re: [PATCH V4] tty/serial: add support for Xilinx PS UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110506132344.1d166260@lxorguk.ukuu.org.uk>
Date:	Fri, 6 May 2011 13:23:44 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	michal.simek@...alogix.com
Cc:	johnlinn@...cast.net, Greg KH <greg@...ah.com>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	joe@...ches.com, grant likely <grant.likely@...retlab.ca>,
	John Linn <john.linn@...inx.com>
Subject: Re: [PATCH V4] tty/serial: add support for Xilinx PS UART

> I don't agree with this change. NO_IRQ for microblaze, arm and other is -1. BTW: 
> For ppc is 0. Using NO_IRQ seems to me reasonable.

0 means "no interrupt".

The old mis-use of -1 is an old mostly ARM specific ugly that ahould be
going away not getting repeated further. If Microblaze is using this hack
then it needs to stop.

NO_IRQ was *purposefully* removed from general consumption a long time
ago for a good reason (historically it was an IDE driver internal define
certain people borrowed)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/