linux-kernel - Re: [v1] Input: tegra-kbc - modify keypress wakeup logic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110507055641.GA5291@core.coreip.homeip.net>
Date:	Fri, 6 May 2011 22:56:42 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	riyer@...dia.com
Cc:	rydberg@...omail.se, amartin@...dia.com, olof@...om.net,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [v1] Input: tegra-kbc - modify keypress wakeup logic.

Hi Rakesh,

On Mon, May 02, 2011 at 05:23:08PM -0700, riyer@...dia.com wrote:
> From: Rakesh Iyer <riyer@...dia.com>
> 
> Modify wakeup logic so either all keypresses wake the system or none do.
> 
> Signed-off-by: Rakesh Iyer <riyer@...dia.com>
> ---
> v1: Modify wakeup logic so either all keypresses wake the system or none do.
> 
>  arch/arm/mach-tegra/include/mach/kbc.h |    4 +---
>  drivers/input/keyboard/tegra-kbc.c     |   28 ++++------------------------
>  2 files changed, 5 insertions(+), 27 deletions(-)
> 
> diff --git a/arch/arm/mach-tegra/include/mach/kbc.h b/arch/arm/mach-tegra/include/mach/kbc.h
> index bd99744..6b8e934 100644
> --- a/arch/arm/mach-tegra/include/mach/kbc.h
> +++ b/arch/arm/mach-tegra/include/mach/kbc.h
> @@ -50,14 +50,12 @@ struct tegra_kbc_platform_data {
>  	unsigned int debounce_cnt;
>  	unsigned int repeat_cnt;
>  
> -	unsigned int wake_cnt; /* 0:wake on any key >1:wake on wake_cfg */
> -	const struct tegra_kbc_wake_key *wake_cfg;
> -
>  	struct tegra_kbc_pin_cfg pin_cfg[KBC_MAX_GPIO];
>  	const struct matrix_keymap_data *keymap_data;
>  
>  	bool wakeup;
>  	bool use_fn_map;
>  	bool use_ghost_filter;
> +	bool wake_on_keypress;

Why do we need new wake_on_keypress flag if we already have 'wakeup'?
What besides a keypress can be used as a wakeup source with this device?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/