linux-kernel - Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304867317.3246.10.camel@odin>
Date:	Sun, 08 May 2011 16:08:37 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	balbi@...com
Cc:	Graeme Gregory <gg@...mlogic.co.uk>, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

On Wed, 2011-04-27 at 13:45 +0300, Felipe Balbi wrote:
> Hi,
> 
> On Wed, Apr 27, 2011 at 10:39:51AM +0100, Graeme Gregory wrote:
> > The twl6025 uses a different regulator for USB than the 6030 so select
> > the correct regulator name depending on the subclass of device.
> > 
> > Signed-off-by: Graeme Gregory <gg@...mlogic.co.uk>
> 
> I don't see the point of this patch. It's just a string. Use the same
> name and add a comment saying that on datasheet/TRM/documentation the
> name LDO is actually referred to as LDOUSB. It's the same functionality
> anyway.
> 

I think for the avoidance of any doubt, it's probably best to use the
TWL6025 string name here as it will importantly match the TWL6025 TRM
and any schematics using the TWL6025. Getting this wrong during TWL6025
board integration has the potential for hardware damage.

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/