linux-kernel - Re: [RFC PATCH] hpsa: Change memset using sizeof(ptr) to sizeof(*ptr)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110509135251.GE5997@beardog.cce.hp.com>
Date:	Mon, 9 May 2011 08:52:51 -0500
From:	scameron@...rdog.cce.hp.com
To:	Joe Perches <joe@...ches.com>
Cc:	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	iss_storagedev@...com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] hpsa: Change memset using sizeof(ptr) to sizeof(*ptr)

On Sun, May 08, 2011 at 11:32:40PM -0700, Joe Perches wrote:
> Not at all sure this is correct or appropriate to change,
> but this seems odd.
> 
> Found via coccinelle script

Ack.

-- steve

> 
> @@
> type T;
> T* ptr;
> expression E1;
> @@
> 
> * memset(E1, 0, sizeof(ptr));
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/scsi/hpsa.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 415ad4f..c8d97b4 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -1308,7 +1308,7 @@ static void hpsa_scsi_do_simple_cmd_with_retry(struct ctlr_info *h,
>  	int retry_count = 0;
>  
>  	do {
> -		memset(c->err_info, 0, sizeof(c->err_info));
> +		memset(c->err_info, 0, sizeof(*c->err_info));
>  		hpsa_scsi_do_simple_cmd_core(h, c);
>  		retry_count++;
>  	} while (check_for_unit_attention(h, c) && retry_count <= 3);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/