linux-kernel - Re: [PATCH v4 08/11] tty: add pruss SUART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110509145534.2677dfa1@lxorguk.ukuu.org.uk>
Date:	Mon, 9 May 2011 14:55:34 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Subhasish Ghosh" <subhasish@...tralsolutions.com>
Cc:	<davinci-linux-open-source@...ux.davincidsp.com>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	<linux-arm-kernel@...ts.infradead.org>, <m-watkins@...com>,
	<nsekhar@...com>, <sachi@...tralsolutions.com>,
	"Andrew Morton \(commit_signer:1/4=25%\)" <akpm@...ux-foundation.org>,
	"Randy Dunlap \(commit_signer:1/4=25%\)" <randy.dunlap@...cle.com>,
	"open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 08/11] tty: add pruss SUART driver

On Mon, 9 May 2011 19:20:17 +0530
"Subhasish Ghosh" <subhasish@...tralsolutions.com> wrote:

> >> I then modified this function to as follows and the error is not observed
> >> anymore.
> >
> > That looks like you are somehow calling uart_carrier_raised somewhere
> > with interrupts disabled ?
> >
> I am not calling this function in my driver atall, this is getting called by 
> tty_port.c

Can you verify the status of the interrupt flags at the point that
routine is called in your code and get a backtrace of the path. It
should never be gettng called with interrupts off, and if it is we need
to know what the path is. Otherwise that code change would imply a bug
in the core code for the platform which seems less likely.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/