linux-kernel - Re: Please don't hijack patches - even trivial ones (was: Re: [PATCH 13/14] HPFS: Move declaration up, so that there are no out-of-scope pointers=

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1105100022400.19722@swampdragon.chaosbits.net>
Date:	Tue, 10 May 2011 00:29:50 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: Please don't hijack patches - even trivial ones (was: Re: [PATCH
 13/14] HPFS: Move declaration up, so that there are no out-of-scope
 pointers=

On Tue, 10 May 2011, Mikulas Patocka wrote:

> 
> 
> On Mon, 9 May 2011, Jesper Juhl wrote:
> 
> > On Sun, 8 May 2011, Mikulas Patocka wrote:
> > 
> > > Move declaration up, so that there are no out-of-scope pointers
> > > 
> > > Reported-by: Jesper Juhl <jj@...osbits.net>
> > > Signed-off-by: Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>
> > > 
> 
> So change it to:
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> 
Kinda hard when it's already merged in mainline ;-)


> > Hmm. I'm a little currious how my original Signed-off-by got turned into a 
> > Reported-by for this patch?
> 
> I don't know. I probably checked the code independently after your report 
> and ended up fixing exactly the same thing that you fixed.
> 
Just seems a little odd that you would check the code based on my report 
(you must have been aware of it given the reported-by) and then ending up 
with the exact same fix would chose to submit a completely new patch with 
the exact same contents but with you as author...

Ohh well, never mind - it's a trivial patch and the important thing is 
that it got merged. I just got a little annoyed at seeing a patch that I 
had submitted and even ping'ed people about later, getting merged with a 
different author and me just listed as 'reported-by'... I just care about 
these things, even for trivial stuff - it's a matter of "credit where 
credit is due" even when the change is minor...

but let's just leave it where it is - the fix got merged, that's the 
really important bit :-)

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/