linux-kernel - Re: [PATCH 08/11] ptrace: move fallback JOBCTL_TRAPPING clearing to get_signal_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110511191731.GA24245@mtj.dyndns.org>
Date:	Wed, 11 May 2011 21:17:31 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	jan.kratochvil@...hat.com, vda.linux@...glemail.com,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, indan@....nu
Subject: Re: [PATCH 08/11] ptrace: move fallback JOBCTL_TRAPPING clearing
 to get_signal_to_deliver()

Hello,

On Wed, May 11, 2011 at 05:48:34PM +0200, Oleg Nesterov wrote:
> On 05/08, Tejun Heo wrote:
> > Move the fallback clearing to the end of get_signal_to_deliver() so
> > that TRAPPING is maintained while tracee is inside signal delivery
> > path.  When killed, tracee is guaranteed to leave signal delivery path
> > in finite amount of time and thus TRAPPING is still guaranteed to be
> > cleared on kill.
> 
> Mostly yes, but we can race with freeze_processes() and deadlock.

Ah... the try_to_freeze().  Nice spotting.  It isn't necessarily a
deadlock tho.  freeze_processes() will back out after a while.  I
think the right thing to do here is making the TRAPPING sleep an
interruptible one and let the syscall restart logic deal with it.
This will also remove the dreaded unkillable tracer even if we get
something wrong somewhere.  How does that sound?

> And. The main problem is that "leave signal delivery path" is not true
> at all. When the tracee dequeues SIGKILL it calls do_group_exit() inside
> the main loop.
> 
> So far this all looks easily fixeable though...

Yeah, as I wrote before, I wanna do two things.

* Make TRAPPING wait INTERRUPTIBLE.

* Move clearing of pending group stop and traps to the actions which
  require such clearing.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/