linux-kernel - Re: [PATCH] 8250_pci: Add support for the Digi/IBM PCIe 2-port Adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110511203151.GA28160@suse.de>
Date:	Wed, 11 May 2011 13:31:51 -0700
From:	Greg KH <gregkh@...e.de>
To:	"Kilau, Scott" <Scott.Kilau@...i.com>
Cc:	"'mreed10@...ibm.com'" <mreed10@...ibm.com>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	'Alan Cox' <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] 8250_pci: Add support for the Digi/IBM PCIe 2-port
 Adapter

On Wed, May 11, 2011 at 03:27:25PM -0500, Kilau, Scott wrote:
> > From: Greg KH [mailto:gregkh@...e.de] 
> > Sent: Wednesday, May 11, 2011 2:43 PM
> > To: Kilau, Scott
> > Cc: 'mreed10@...ibm.com'; 'linux-kernel@...r.kernel.org'; 'Alan Cox'
> > Subject: Re: [PATCH] 8250_pci: Add support for the Digi/IBM PCIe 2-port Adapter
> 
> > On Wed, May 11, 2011 at 02:28:07PM -0500, Kilau, Scott wrote:
> > > --- linux-2.6.38.6-vanilla/include/linux/pci_ids.h	2011-04-21 16:34:46.000000000 -0500
> > > +++ linux-2.6.38.6/include/linux/pci_ids.h	2011-04-27 14:56:30.000000000 -0500
> > > @@ -1476,6 +1476,7 @@
> > >  #define PCI_DEVICE_ID_NEO_2RJ45         0x00CA
> > >  #define PCI_DEVICE_ID_NEO_2RJ45PRI      0x00CB
> > >  #define PCIE_DEVICE_ID_NEO_4_IBM        0x00F4
> > > +#define PCIE_DEVICE_ID_NEO_2_OX_IBM     0x00F6
> 
> > Please see the top of this file for why you shouldn't be adding new
> > device ids into it.
> > Third time's a charm?
> > thanks,
> > greg k-h
> 
> Sorry about that.
> Should I just be putting them into 8250_pci.c directly instead?

Yes.

> I was conflicted as to where to put it, as I saw this comment in
> 8250_pci.c, before a list of device ids:
> /* This should be in linux/pci_ids.h */

That comment should be removed :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/