lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 11 May 2011 15:31:49 +0300
From:	Roger Quadros <roger.quadros@...ia.com>
To:	ext Michal Nazarewicz <mina86@...a86.com>
CC:	<gregkh@...e.de>, <stern@...land.harvard.edu>,
	<sshtylyov@...sta.com>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] usb: gadget: storage: Add fsg_get_toc helper

On 05/11/2011 03:19 PM, ext Michal Nazarewicz wrote:
>> On 04/05/2011 06:43 PM, ext Michal Nazarewicz wrote:
>>> On Tue, 05 Apr 2011 16:59:27 +0200, Roger Quadros wrote:
>>>> + default:
>>>> + /* Multi-session, PMA, ATIP, CD-TEXT not supported/required */
>>>> + return -EINVAL;
>
>> On 04/05/2011 06:43 PM, ext Michal Nazarewicz wrote:
>>> Can we fall back to the old behaviour here?
>
> On Wed, 11 May 2011 09:49:36 +0200, Roger Quadros <roger.
>> What old behaviour? I didn't understand.
>
> Before we were just ignoring the type of ToC requested, right?
> So can we fail back to the ToC we served then when we hit
> an unsupported TOC? Or does it make no sense at all? I'm not
> saying it does. It probably doesn't. ;)
>

Before we were returning -EINVAL for unsupported request. We do the same now.

-- 
regards,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists