linux-kernel - Re: [PATCH v2] net: rfkill: add generic gpio rfkill driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1305189092.3461.10.camel@jlt3.sipsolutions.net>
Date:	Thu, 12 May 2011 10:31:32 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Rhyland Klein <rklein@...dia.com>
Cc:	olof@...om.net, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: rfkill: add generic gpio rfkill driver

On Wed, 2011-05-11 at 17:21 -0700, Rhyland Klein wrote:

> +enum rfkill_gpio_clk_state {
> +	UNSPECIFIED = 0,
> +	PWR_ENABLED,
> +	PWR_DISABLED

Are you sure starting out with UNSPECIFIED works? Then you'll always
change, but if the clock was enabled already you still enable it on the
first set_block() from rfkill, which still has the refcount problem, no?
It seems to me that the original state has to be passed in from the
platform?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/