linux-kernel - Re: [PATCH] spi: tle620x: add missing device_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DCB9985.2050100@simtec.co.uk>
Date:	Thu, 12 May 2011 09:25:41 +0100
From:	Ben Dooks <ben@...tec.co.uk>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org,
	Grant Likely <grant.likely@...retlab.ca>,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH] spi: tle620x: add missing device_remove_file()

On 11/05/11 13:39, Axel Lin wrote:
> This patch includes below fixes:
> 1. Add missing device_remove_file for dev_attr_status_show in tle62x0_remove.
> 2. Fix tle62x0_probe error handling:
>     Currently, if the error happens when ptr>  0, gpio_attrs[0] is not
>     properly remove.
>
> Signed-off-by: Axel Lin<axel.lin@...il.com>
Acked-by: Ben Dooks <ben-linux@...ff.org>
> ---
>   drivers/spi/tle62x0.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/tle62x0.c b/drivers/spi/tle62x0.c
> index a393895..32a4087 100644
> --- a/drivers/spi/tle62x0.c
> +++ b/drivers/spi/tle62x0.c
> @@ -283,7 +283,7 @@ static int __devinit tle62x0_probe(struct spi_device *spi)
>   	return 0;
>
>    err_gpios:
> -	for (; ptr>  0; ptr--)
> +	while (--ptr>= 0)
>   		device_remove_file(&spi->dev, gpio_attrs[ptr]);
>
>   	device_remove_file(&spi->dev,&dev_attr_status_show);
> @@ -301,6 +301,7 @@ static int __devexit tle62x0_remove(struct spi_device *spi)
>   	for (ptr = 0; ptr<  st->nr_gpio; ptr++)
>   		device_remove_file(&spi->dev, gpio_attrs[ptr]);
>
> +	device_remove_file(&spi->dev,&dev_attr_status_show);
>   	kfree(st);
>   	return 0;
>   }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/