linux-kernel - Re: [PATCHv2 5/5] TPS65911: Comparator: Add comparator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 May 2011 15:29:45 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org, lrg@...com,
	Graeme Gregory <gg@...mlogic.co.uk>, grant.likely@...retlab.ca
Subject: Re: [PATCHv2 5/5] TPS65911: Comparator: Add comparator driver

On Fri, May 13, 2011 at 06:59:32PM +0200, Samuel Ortiz wrote:
> On Wed, May 04, 2011 at 07:21:46PM -0500, Jorge Eduardo Candelaria wrote:

> > +config TPS65911_COMPARATOR
> > +	tristate "TPS65911 Comparator"
> > +	depends on MFD_TPS65910
> > +	help
> > +	  if you say yes here you get support for the TPS65910 comparator
> > +	  module.

> I still don't know what it compares and why I would want to enable that.

It'll be comparing two voltages - it's quite a common feature for PMICs
with auxadcs.  I think I said in one of my previous reviews that it
probably shouldn't be user visible in Kconfig as some other driver will
need to be written to call it so that driver could just select the
symbol.

> This driver really looks like it could belong to drivers/regulator.

It's measuring rather than producing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/