linux-kernel - Re: [PATCHv2 5/5] TPS65911: Comparator: Add comparator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110522204056.GH18610@sortiz-mobl>
Date:	Sun, 22 May 2011 22:40:57 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org, lrg@...com,
	Graeme Gregory <gg@...mlogic.co.uk>, grant.likely@...retlab.ca
Subject: Re: [PATCHv2 5/5] TPS65911: Comparator: Add comparator driver

On Sat, May 14, 2011 at 03:29:45PM -0700, Mark Brown wrote:
> On Fri, May 13, 2011 at 06:59:32PM +0200, Samuel Ortiz wrote:
> > On Wed, May 04, 2011 at 07:21:46PM -0500, Jorge Eduardo Candelaria wrote:
> 
> > > +config TPS65911_COMPARATOR
> > > +	tristate "TPS65911 Comparator"
> > > +	depends on MFD_TPS65910
> > > +	help
> > > +	  if you say yes here you get support for the TPS65910 comparator
> > > +	  module.
> 
> > I still don't know what it compares and why I would want to enable that.
> 
> It'll be comparing two voltages - it's quite a common feature for PMICs
> with auxadcs.  I think I said in one of my previous reviews that it
> probably shouldn't be user visible in Kconfig as some other driver will
> need to be written to call it so that driver could just select the
> symbol.
> 
> > This driver really looks like it could belong to drivers/regulator.
> 
> It's measuring rather than producing.
Sure, but I still don't see how it belongs to drivers/mfd/.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/