linux-kernel - Re: [PATCH] net: ipv6: mcast: Removing invalid check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTikeeBdFrnPX7J=uRswFZm-mwUxh=w@mail.gmail.com>
Date:	Sat, 14 May 2011 17:45:39 +0300
From:	Maxin B John <maxin.john@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kaber@...sh.net, yoshfuji@...ux-ipv6.org, jmorris@...ei.org,
	pekkas@...core.fi, kuznet@....inr.ac.ru, davem@...emloft.net
Subject: Re: [PATCH] net: ipv6: mcast: Removing invalid check

Hi,

> At a first glance, I would say Coverity is wrong, unless you can explain
> why it's right ;)
>
> first can be 0 at this point, we are in a loop.

You are right.

> BTW "Removing invalid check" is a really wrong patch title.
>
> Once you can prove your point, you should use "Remove useless check"
>

I will keep it in mind. Thanks .

Best Regards,
Maxin B John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/