linux-kernel - Re: [PATCH] PM: Remove CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201105162032.33480.rjw@sisk.pl>
Date:	Mon, 16 May 2011 20:32:33 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Linux PM mailing list <linux-pm@...ts.linux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-sh@...r.kernel.org
Subject: Re: [PATCH] PM: Remove CONFIG_PM_VERBOSE

On Saturday, May 14, 2011, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> Now that we have CONFIG_DYNAMIC_DEBUG there is no need for yet
> another flag causing dev_dbg() and pr_debug() statements in the
> core PM code to produce output.  Moreover, CONFIG_PM_VERBOSE
> causes so much output to be generated that it's not really useful
> and almost no one sets it.
> 
> References: https://bugzilla.kernel.org/show_bug.cgi?id=23182
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

There are no comments, so my understanding is that no one has any objections to
this patch.  If that really is the case, I'm going to put it into
suspend-2.6/linux-next for 2.6.40.

Thanks,
Rafael


> ---
>  arch/sh/configs/apsh4ad0a_defconfig |    1 -
>  arch/sh/configs/sdk7786_defconfig   |    1 -
>  drivers/base/power/Makefile         |    3 +--
>  kernel/power/Kconfig                |    6 ------
>  4 files changed, 1 insertion(+), 10 deletions(-)
> 
> Index: linux-2.6/arch/sh/configs/apsh4ad0a_defconfig
> ===================================================================
> --- linux-2.6.orig/arch/sh/configs/apsh4ad0a_defconfig
> +++ linux-2.6/arch/sh/configs/apsh4ad0a_defconfig
> @@ -48,7 +48,6 @@ CONFIG_PREEMPT=y
>  CONFIG_BINFMT_MISC=y
>  CONFIG_PM=y
>  CONFIG_PM_DEBUG=y
> -CONFIG_PM_VERBOSE=y
>  CONFIG_PM_RUNTIME=y
>  CONFIG_CPU_IDLE=y
>  CONFIG_NET=y
> Index: linux-2.6/arch/sh/configs/sdk7786_defconfig
> ===================================================================
> --- linux-2.6.orig/arch/sh/configs/sdk7786_defconfig
> +++ linux-2.6/arch/sh/configs/sdk7786_defconfig
> @@ -83,7 +83,6 @@ CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y
>  CONFIG_BINFMT_MISC=y
>  CONFIG_PM=y
>  CONFIG_PM_DEBUG=y
> -CONFIG_PM_VERBOSE=y
>  CONFIG_PM_RUNTIME=y
>  CONFIG_CPU_IDLE=y
>  CONFIG_NET=y
> Index: linux-2.6/drivers/base/power/Makefile
> ===================================================================
> --- linux-2.6.orig/drivers/base/power/Makefile
> +++ linux-2.6/drivers/base/power/Makefile
> @@ -5,5 +5,4 @@ obj-$(CONFIG_PM_TRACE_RTC)	+= trace.o
>  obj-$(CONFIG_PM_OPP)	+= opp.o
>  obj-$(CONFIG_HAVE_CLK)	+= clock_ops.o
>  
> -ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
> -ccflags-$(CONFIG_PM_VERBOSE)   += -DDEBUG
> +ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
> \ No newline at end of file
> Index: linux-2.6/kernel/power/Kconfig
> ===================================================================
> --- linux-2.6.orig/kernel/power/Kconfig
> +++ linux-2.6/kernel/power/Kconfig
> @@ -125,12 +125,6 @@ config PM_DEBUG
>  	code. This is helpful when debugging and reporting PM bugs, like
>  	suspend support.
>  
> -config PM_VERBOSE
> -	bool "Verbose Power Management debugging"
> -	depends on PM_DEBUG
> -	---help---
> -	This option enables verbose messages from the Power Management code.
> -
>  config PM_ADVANCED_DEBUG
>  	bool "Extra PM attributes in sysfs for low-level debugging/testing"
>  	depends on PM_DEBUG
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/