linux-kernel - [PATCH 2/2] x86, AMD: Fix ARAT feature setting again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1305636919-31165-3-git-send-email-bp@amd64.org>
Date:	Tue, 17 May 2011 14:55:19 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Nick Bowler <nbowler@...iptictech.com>,
	Jörg-Volker Peetz <jvpeetz@....de>
Cc:	Boris Ostrovsky <boris.ostrovsky@....com>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Greg Kroah-Hartman <greg@...ah.com>,
	Hans Rosenfeld <hans.rosenfeld@....com>,
	X86-ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>,
	Boris Ostrovsky <Boris.Ostrovsky@....com>
Subject: [PATCH 2/2] x86, AMD: Fix ARAT feature setting again

From: Borislav Petkov <borislav.petkov@....com>

Trying to enable the local APIC timer on early K8 revisions uncovers
a number of other issues with it, in conjunction with the C1E enter
path on AMD. Fixing those causes much more churn and troubles than the
benefit of using that timer brings so don't enable it on K8 at all,
falling back to the original functionality the kernel had wrt to that.

Reported-and-bisected-by: Nick Bowler <nbowler@...iptictech.com>
Cc: Boris Ostrovsky <Boris.Ostrovsky@....com>
Link: http://lkml.kernel.org/r/20110514195741.GA10757@elliptictech.com
Signed-off-by: Borislav Petkov <borislav.petkov@....com>
---
 arch/x86/kernel/cpu/amd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 3532d3b..6f9d1f6 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -613,7 +613,7 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
 #endif
 
 	/* As a rule processors have APIC timer running in deep C states */
-	if (c->x86 >= 0xf && !cpu_has_amd_erratum(amd_erratum_400))
+	if (c->x86 > 0xf && !cpu_has_amd_erratum(amd_erratum_400))
 		set_cpu_cap(c, X86_FEATURE_ARAT);
 
 	/*
-- 
1.7.4.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/