linux-kernel - [tip:x86/urgent] x86, AMD: Fix ARAT feature setting again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-14fb57dccb6e1defe9f89a66f548fcb24c374c1d@git.kernel.org>
Date:	Tue, 17 May 2011 13:47:00 GMT
From:	tip-bot for Borislav Petkov <borislav.petkov@....com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hans.rosenfeld@....com,
	Boris.Ostrovsky@....com, nbowler@...iptictech.com, hpa@...or.com,
	mingo@...hat.com, andreas.herrmann3@....com, greg@...ah.com,
	jvpeetz@....de, tglx@...utronix.de, mingo@...e.hu,
	borislav.petkov@....com
Subject: [tip:x86/urgent] x86, AMD: Fix ARAT feature setting again

Commit-ID:  14fb57dccb6e1defe9f89a66f548fcb24c374c1d
Gitweb:     http://git.kernel.org/tip/14fb57dccb6e1defe9f89a66f548fcb24c374c1d
Author:     Borislav Petkov <borislav.petkov@....com>
AuthorDate: Tue, 17 May 2011 14:55:19 +0200
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Tue, 17 May 2011 15:28:34 +0200

x86, AMD: Fix ARAT feature setting again

Trying to enable the local APIC timer on early K8 revisions
uncovers a number of other issues with it, in conjunction with
the C1E enter path on AMD. Fixing those causes much more churn
and troubles than the benefit of using that timer brings so
don't enable it on K8 at all, falling back to the original
functionality the kernel had wrt to that.

Reported-and-bisected-by: Nick Bowler <nbowler@...iptictech.com>
Cc: Boris Ostrovsky <Boris.Ostrovsky@....com>
Cc: Andreas Herrmann <andreas.herrmann3@....com>
Cc: Greg Kroah-Hartman <greg@...ah.com>
Cc: Hans Rosenfeld <hans.rosenfeld@....com>
Cc: Nick Bowler <nbowler@...iptictech.com>
Cc: Joerg-Volker-Peetz <jvpeetz@....de>
Signed-off-by: Borislav Petkov <borislav.petkov@....com>
Link: http://lkml.kernel.org/r/1305636919-31165-3-git-send-email-bp@amd64.org
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/cpu/amd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 3532d3b..6f9d1f6 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -613,7 +613,7 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
 #endif
 
 	/* As a rule processors have APIC timer running in deep C states */
-	if (c->x86 >= 0xf && !cpu_has_amd_erratum(amd_erratum_400))
+	if (c->x86 > 0xf && !cpu_has_amd_erratum(amd_erratum_400))
 		set_cpu_cap(c, X86_FEATURE_ARAT);
 
 	/*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/