linux-kernel - Re: [PATCH 2/2] drivercore: revert addition of of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 May 2011 17:03:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	grant.likely@...retlab.ca
Cc:	devicetree-discuss@...ts.ozlabs.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org, miltonm@....com,
	sparclinux@...r.kernel.org, torvalds@...ux-foundation.org,
	joy@...uzijast.net
Subject: Re: [PATCH 2/2] drivercore: revert addition of of_match to struct
 device

From: Grant Likely <grant.likely@...retlab.ca>
Date: Wed, 18 May 2011 13:21:05 -0600

> Commit b826291c, "drivercore/dt: add a match table pointer to struct
> device" added an of_match pointer to struct device to cache the
> of_match_table entry discovered at driver match time.  This was unsafe
> because matching is not an atomic operation with probing a driver.  If
> two or more drivers are attempted to be matched to a driver at the
> same time, then the cached matching entry pointer could get
> overwritten.
> 
> This patch reverts the of_match cache pointer and reworks all users to
> call of_match_device() directly instead.
> 
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>

Tested on SunBlade2500 and Niagara2+

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/