linux-kernel - Re: [PATCH 1/2] of: fix race when matching drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110518.170340.1970357603006374415.davem@davemloft.net>
Date:	Wed, 18 May 2011 17:03:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	grant.likely@...retlab.ca
Cc:	devicetree-discuss@...ts.ozlabs.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org, miltonm@....com,
	sparclinux@...r.kernel.org, torvalds@...ux-foundation.org,
	joy@...uzijast.net
Subject: Re: [PATCH 1/2] of: fix race when matching drivers

From: Grant Likely <grant.likely@...retlab.ca>
Date: Wed, 18 May 2011 13:21:00 -0600

> From: Milton Miller <miltonm@....com>
> 
> If two drivers are probing devices at the same time, both will write
> their match table result to the dev->of_match cache at the same time.
> 
> Only write the result if the device matches.
> 
> In a thread titled "SBus devices sometimes detected, sometimes not",
> Meelis reported his SBus hme was not detected about 50% of the time.
>>>From the debug suggested by Grant it was obvious another driver matched
> some devices between the call to match the hme and the hme discovery
> failling.
> 
> Reported-by: Meelis Roos <mroos@...ux.ee>
> Signed-off-by: Milton Miller <miltonm@....com>
> [grant.likely: modified to only call of_match_device() once]
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>

Tested on SunBlade2500 and Niagara2+

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/