linux-kernel - Re: Linux 2.6.39

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110519092318.1a946dce.randy.dunlap@oracle.com>
Date:	Thu, 19 May 2011 09:23:18 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	Mark Lord <kernel@...savvy.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.39

On Thu, 19 May 2011 17:16:32 +0100 Catalin Marinas wrote:

> On 19 May 2011 16:44, Mark Lord <kernel@...savvy.com> wrote:
> > Here's some more funny business that was new after rc7-git12:
> >
> > warning: (AX88796_93CX6 && RTL8180 && RTL8187 && ADM8211 && RT2400PCI &&
> > RT2500PCI && RT61PCI && RT2800PCI && R8187SE) selects EEPROM_93CX6 which has
> > unmet direct dependencies (MISC_DEVICES)
> > warning: (ACPI_APEI) selects PSTORE which has unmet direct dependencies
> > (MISC_FILESYSTEMS)
> >
> > The exact same .config didn't do that with rc7-git12,
> > but does do it with 2.6.39 final.
> >
> > Odd thing is, if I select both MISC_DEVICES and MISC_FILESYSTEMS,
> > but do NOT select anything from under either of those,
> > the warnings go away.
> >
> > Which likely means the warnings are totally bogus.
> 
> The problem is:
> 
> AX88796_93CX6 selects EEPROM_93CX6
> EEPROM_93CX6 depends on MISC_DEVICES (as part of the EEPROM menu which
> is only included if MISC_DEVICES)
> 
> By enabling MISC_DEVICES, you allow AX88796_93CX6 to select
> EEPROM_93CX6 without any warning as it has the dependencies met.
> 
> The issue here is that EEPROM_93CX6 doesn't really depend on any
> MISC_DEVICES infrastructure. That's just a directory for various
> drivers and MISC_DEVICES only has a visibility role. There was a
> proposal last year for kbuild to differentiate between dependency and
> visibility but I don't know what happened to it.

fwiw, there is a VISIBLE attribute now.  It defaults to yes/on.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/