linux-kernel - Re: [PATCH v2] perf, x86: Fix event scheduler for constraints with overlapping counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110519180650.GC6139@elte.hu>
Date:	Thu, 19 May 2011 20:06:50 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Robert Richter <robert.richter@....com>,
	Stephane Eranian <eranian@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] perf, x86: Fix event scheduler for constraints with
 overlapping counters

* Peter Zijlstra <peterz@...radead.org> wrote:

> On Wed, 2011-05-18 at 23:20 +0200, Ingo Molnar wrote:
> > * Peter Zijlstra <peterz@...radead.org> wrote:
> > 
> > > >                         if (c->weight != w)
> > > >                                 continue;
> > > >  
> > > > -                       for_each_set_bit(j, c->idxmsk, X86_PMC_IDX_MAX) {
> > > > -                               if (!test_bit(j, used_mask))
> > > > +                       /* for each bit in idxmsk starting from idx */
> > > > +                       while (idx < X86_PMC_IDX_MAX) {
> > > > +                               idx = find_next_bit(c->idxmsk, X86_PMC_IDX_MAX,
> > > > +                                                   idx);
> > > 
> > > I'd be mighty tempted to ignore that 80 column rule here ;-)
> > 
> > Please put the body of the loop into a helper function, the function is large 
> > and there are countless col80 uglinesses in it!
> 
> I just tried that, its real ugly due to the amount of state you need to
> pass around.

Does it help if you put that state into a helper structure?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/