linux-kernel - Re: [patch 6/6] x86, apic: use .apicdrivers section to find the list of apic drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 May 2011 18:35:01 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
CC:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com, steiner@....com,
	yinghai@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 6/6] x86, apic: use .apicdrivers section to find the list
 of apic drivers

On 05/20/2011 03:45 AM, Suresh Siddha wrote:
> This will enable each apic driver to be self-contained and eliminate the need
> for apic_probe[].
> 
> Apic probe will now depend on the order in which apic drivers are listed in
> the .apicdrivers section. Ordering of apic driver files in the Makefile
> and the macros apic_driver()/apic_drivers() help enforce the desired order.
> 
> Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
> ---
...
> Index: linux-2.6-tip/arch/x86/kernel/vmlinux.lds.S
> ===================================================================
> --- linux-2.6-tip.orig/arch/x86/kernel/vmlinux.lds.S
> +++ linux-2.6-tip/arch/x86/kernel/vmlinux.lds.S
> @@ -305,6 +305,12 @@ SECTIONS
>  		__iommu_table_end = .;
>  	}
>  

Seems we miss ALIGN here, no?

	. = ALIGN(8);

> +	.apicdrivers : AT(ADDR(.apicdrivers) - LOAD_OFFSET) {
> +		__apicdrivers = .;
> +		*(.apicdrivers);
> +		__apicdrivers_end = .;
> +	}
> +
...
-- 
    Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/