linux-kernel - Re: [patch 6/6] x86, apic: use .apicdrivers section to find the list of apic drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1305913295.13584.4303.camel@sbsiddha-MOBL3.sc.intel.com>
Date:	Fri, 20 May 2011 10:41:35 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"steiner@....com" <steiner@....com>,
	"yinghai@...nel.org" <yinghai@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"gorcunov@...nvz.org" <gorcunov@...nvz.org>
Subject: Re: [patch 6/6] x86, apic: use .apicdrivers section to find the
 list of apic drivers

On Fri, 2011-05-20 at 06:01 -0700, Ingo Molnar wrote:
> * Suresh Siddha <suresh.b.siddha@...el.com> wrote:
> 
> > This will enable each apic driver to be self-contained and eliminate the need
> > for apic_probe[].
> > 
> > Apic probe will now depend on the order in which apic drivers are listed in
> > the .apicdrivers section. Ordering of apic driver files in the Makefile
> > and the macros apic_driver()/apic_drivers() help enforce the desired order.
> > 
> > Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
> > ---
> >  arch/x86/include/asm/apic.h           |   25 ++++++++++---
> >  arch/x86/kernel/apic/Makefile         |   17 +++++---
> >  arch/x86/kernel/apic/apic_flat_64.c   |   11 ++++-
> >  arch/x86/kernel/apic/bigsmp_32.c      |    2 +
> >  arch/x86/kernel/apic/es7000_32.c      |    9 +++-
> >  arch/x86/kernel/apic/numaq_32.c       |    7 ++-
> >  arch/x86/kernel/apic/probe_32.c       |   65 ++++++++++++----------------------
> >  arch/x86/kernel/apic/probe_64.c       |   43 ++++++----------------
> >  arch/x86/kernel/apic/summit_32.c      |    4 +-
> >  arch/x86/kernel/apic/x2apic_cluster.c |    4 +-
> >  arch/x86/kernel/apic/x2apic_phys.c    |    6 ++-
> >  arch/x86/kernel/apic/x2apic_uv_x.c    |    6 ++-
> >  arch/x86/kernel/vmlinux.lds.S         |    6 +++
> >  13 files changed, 111 insertions(+), 94 deletions(-)
> 
> This patch crashes one of my testboxes (AMD X2 whitebox, config attached). No 
> crashlog.

oops. obviously just testing on small and big servers was not enough :(

flat mode was broken, as it had null probe routine. Old code didn't have
flat mode listed in the apic probe array (as the flat mode was the
default option). Will fix it and split it into multiple patches.

thanks.
> 
> The patch is also clearly too large and should be split up into 4 pieces:
> 
>  - there should be a patch adding the whole driver section thing and marking 
>    all the existing APIC drivers with it
> 
>  - one patch adding the functions doing the new-style probing.
> 
>  - one patch flipping over from old-style to new-style probing
> 
>  - a final patch removing all the stale functions and marking the APIC driver
>    probe functions static.
> 
> Thanks,
> 
> 	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/