linux-kernel - Re: [PATCH] ds2760_battery: Fix rated capacity of the hx4700 1800mAh battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110520154724.GB18099@oksana.dev.rtsoft.ru>
Date:	Fri, 20 May 2011 19:47:24 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Paul Parsons <lost.distance@...oo.com>
Cc:	linux-kernel@...r.kernel.org, dwmw2@...radead.org,
	Dmitry Artamonow <mad_soft@...ox.ru>,
	Philipp Zabel <philipp.zabel@...il.com>
Subject: Re: [PATCH] ds2760_battery: Fix rated capacity of the hx4700
 1800mAh battery

On Mon, Apr 25, 2011 at 01:45:40PM +0000, Paul Parsons wrote:
> Fix rated capacity of the HP iPAQ hx4700 3.7V 1800mAh (359113-001) battery. For this battery the value of the rated capacity EEPROM register at 0x32 is 7; thus rated_capacities[7] = 1800.
> 
> Signed-off-by: Paul Parsons <lost.distance@...oo.com>

Applied, thanks!

> ---
> --- clean-2.6.39-rc4/drivers/power/ds2760_battery.c	2011-03-15 01:20:32.000000000 +0000
> +++ linux-2.6.39-rc4/drivers/power/ds2760_battery.c	2011-04-25 13:06:29.344976841 +0100
> @@ -86,7 +86,11 @@ static int rated_capacities[] = {
>  	920,	/* NEC */
>  	1440,	/* Samsung */
>  	1440,	/* BYD */
> +#ifdef CONFIG_MACH_H4700

Note that this is OK as a temporary fix, but in general such fixups
should be done via platform data. So, it would be great if you could
prepare another patch on top of this one, which would do things in
a proper way.

> +	1800,	/* HP iPAQ hx4700 3.7V 1800mAh (359113-001) */
> +#else
>  	1440,	/* Lishen */
> +#endif
>  	1440,	/* NEC */
>  	2880,	/* Samsung */
>  	2880,	/* BYD */

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/