linux-kernel - Re: [PATCH] ds2760_battery: Fix rated capacity of the hx4700 1800mAh battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110520174546.GA27734@rainbow>
Date:	Fri, 20 May 2011 21:45:46 +0400
From:	Dmitry Artamonow <mad_soft@...ox.ru>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Paul Parsons <lost.distance@...oo.com>,
	linux-kernel@...r.kernel.org, dwmw2@...radead.org,
	Philipp Zabel <philipp.zabel@...il.com>
Subject: Re: [PATCH] ds2760_battery: Fix rated capacity of the hx4700 1800mAh
 battery

On 19:47 Fri 20 May     , Anton Vorontsov wrote:
> On Mon, Apr 25, 2011 at 01:45:40PM +0000, Paul Parsons wrote:

[snip]

> > --- clean-2.6.39-rc4/drivers/power/ds2760_battery.c	2011-03-15 01:20:32.000000000 +0000
> > +++ linux-2.6.39-rc4/drivers/power/ds2760_battery.c	2011-04-25 13:06:29.344976841 +0100
> > @@ -86,7 +86,11 @@ static int rated_capacities[] = {
> >  	920,	/* NEC */
> >  	1440,	/* Samsung */
> >  	1440,	/* BYD */
> > +#ifdef CONFIG_MACH_H4700
> > +	1800,	/* HP iPAQ hx4700 3.7V 1800mAh (359113-001) */
> > +#else
> >  	1440,	/* Lishen */
> > +#endif
> >  	1440,	/* NEC */
> 
> Note that this is OK as a temporary fix, but in general such fixups
> should be done via platform data. So, it would be great if you could
> prepare another patch on top of this one, which would do things in
> a proper way.

BTW, hx4700 also have extended batteries. I personally have one that rated
3600mAh with my hx4700. Sadly I dropped it on the floor some time ago and
battery lock got broken, so I currently can't use it. But I hope to fix it
some day.

It looks like this one, but made by PALMEXX (Part No.359113-001):
http://www.amazon.com/Li-Ion-359113-001-Battery-hx4700-hx4705/dp/B000VN7QMQ

-- 
Best regards,
Dmitry "MAD" Artamonow

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/