linux-kernel - Re: [PATCH 3/3] in scripts/export_report.pl use warn() to issue WARNING, so they go to stderr.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110523082103.ccced65c.rdunlap@xenotime.net>
Date:	Mon, 23 May 2011 08:21:03 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Jim Cromie <jim.cromie@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH 3/3] in scripts/export_report.pl use warn() to issue
 WARNING, so they go to stderr.

On Sat, 21 May 2011 02:21:48 -0600 Jim Cromie wrote:

> Also count CONFIG_MODVERSION warnings, and print an NB message at

CONFIG_MODVERSIONS

NB?  as in Note Well?

Please just use NOTE:

> start of SECTION 2 if any were issued.  Section 2 will be empty
> if the build is lacking this CONFIG_ item, and user may have missed
> the warnings, as they're off screen.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>  scripts/export_report.pl |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
> index 16bd240..14c1638 100644
> --- a/scripts/export_report.pl
> +++ b/scripts/export_report.pl
> @@ -102,6 +102,8 @@ close($module_symvers);
>  #
>  # collect the usage count of each symbol.
>  #
> +my $modversion_warnings = 0;
> +
>  foreach my $thismod (@allcfiles) {
>  	my $module;
>  
> @@ -132,7 +134,8 @@ foreach my $thismod (@allcfiles) {
>  		}
>  	}
>  	if ($state != 2) {
> -		print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n";
> +		warn "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n";

should be CONFIG_MODVERSIONS

> +		$modversion_warnings++;
>  	}
>  	close($module);
>  }
> @@ -166,6 +169,9 @@ printf("SECTION 2:\n\tThis section reports export-symbol-usage of in-kernel
>  modules. Each module lists the modules, and the symbols from that module that
>  it uses.  Each listed symbol reports the number of modules using it\n");
>  
> +print "\nNB: Got $modversion_warnings CONFIG_MODVERSION warnings\n\n"

should be CONFIG_MODVERSIONS

and NOTE:


> +    if $modversion_warnings;
> +
>  print "~"x80 , "\n";
>  for my $thismod (sort keys %MODULE) {
>  	my $list = $MODULE{$thismod};
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/