linux-kernel - Re: [PATCH] sched: remove noop in next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1105241615080.7986@swampdragon.chaosbits.net>
Date:	Tue, 24 May 2011 16:16:15 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Hillf Danton <dhillf@...il.com>
cc:	Mike Galbraith <efault@....de>, Yong Zhang <yong.zhang0@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] sched: remove noop in next_prio()

On Tue, 24 May 2011, Hillf Danton wrote:

> On Tue, May 24, 2011 at 7:53 PM, Mike Galbraith <efault@....de> wrote:
> > On Tue, 2011-05-24 at 16:17 +0800, Yong Zhang wrote:
> >> On Sat, May 21, 2011 at 10:19 PM, Hillf Danton <dhillf@...il.com> wrote:
> >> > When computing the next priority for a given run-queue, the check for
> >> > RT priority of the task determined by the pick_next_highest_task_rt()
> >> > function could be removed, since only RT task is returned by the
> >> > function.
> >> >
> >> > Signed-off-by: Hillf Danton <dhillf@...il.com>
> >>
> >> Yup, it's true.
> >
> > (could whack the else while there)
> >
> 
> Where is it, Mike?
> 


-       if (next && rt_prio(next->prio))
+       if (next)
               return next->prio;
-       else
-              return MAX_RT_PRIO;
+       return MAX_RT_PRIO;



-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/