| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 May 2011 23:26:32 +0900 From: Hiromu Yakura <hiromu1996@...il.com> To: Michal Marek <mmarek@...e.cz> Cc: Arnaud Lacombe <lacombar@...il.com>, linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, zippel@...ux-m68k.org Subject: Re: [PATCH] Kconfig: add warning about permission of config file Hello, On Fri, May 24, 2011 at 22:23, Michal Marek <mmarek@...e.cz> wrote: > Arnaud's point is that your patch should not be necessary at all, > because kconfig already checks the return value of the fopen() call in > conf_write() and prints the above message if it fails. So do you have a > testcase where make <...>config without your patch returns without > error, but the configuration is not written? Sorry for misunderstanding. Indeed, make *config which use 'conf' (e.g. oldconfig, defconfig...) raise error. And only xconfig and gconfig don't write the configuration without error. However, make *config using 'conf' hasn't function of 'Save as'. In other words, if you don't set the write permission to the directory, you would lose changes of the configuration. I think that it is necessary to check permission at all so that kconfig warn of the possibility of losing changes. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists