linux-kernel - Re: [PATCH] Kconfig: add warning about permission of config file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DDBC846.8050402@suse.cz>
Date:	Tue, 24 May 2011 17:01:26 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Hiromu Yakura <hiromu1996@...il.com>
Cc:	Arnaud Lacombe <lacombar@...il.com>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, zippel@...ux-m68k.org
Subject: Re: [PATCH] Kconfig: add warning about permission of config file

On 24.5.2011 16:26, Hiromu Yakura wrote:
> Hello,
>
> On Fri, May 24, 2011 at 22:23, Michal Marek<mmarek@...e.cz>  wrote:
>> Arnaud's point is that your patch should not be necessary at all,
>> because kconfig already checks the return value of the fopen() call in
>> conf_write() and prints the above message if it fails. So do you have a
>> testcase where make<...>config without your patch returns without
>> error, but the configuration is not written?
> Sorry for misunderstanding.
> Indeed, make *config which use 'conf' (e.g. oldconfig, defconfig...)
> raise error.
> And only xconfig and gconfig don't write the configuration without
> error.

I see, qconf lacks a check for the return value of conf_write() in 
ConfigMainWindow::closeEvent(), gconf does check the return value, but 
only displays it in the bottom box of the main window instead of a 
message box. Neither of them return failure in the error case. These 
bugs should be indeed fixed. But I don't like the directory permission 
check, it only handles one case, but does not handle permission on the 
.config file itself with KCONFIG_OVERWRITECONFIG=1, ENOSPC and so on.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/