linux-kernel - Re: [PATCH]: Fix Ultrastor asm snippet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1306258124.10201.22.camel@mulgrave.site>
Date:	Tue, 24 May 2011 13:28:44 -0400
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Samuel Thibault <samuel.thibault@...-lyon.org>,
	James.Bottomley@...e.de, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH]: Fix Ultrastor asm snippet

On Fri, 2011-05-20 at 14:24 +0100, Alan Cox wrote:
> On Fri, 20 May 2011 09:02:15 -0400
> Christoph Hellwig <hch@...radead.org> wrote:
> 
> > On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> > > Commit 1292500b replaced
> > > 
> > > "=m" (*field) : "1" (*field)
> > > 
> > > with
> > > 
> > > "=m" (*field) :
> > > 
> > > with comment "The following patch fixes it by using the '+' operator on
> > > the (*field) operand, marking it as read-write to gcc."
> > > '+' was actually forgotten.  This really puts it.
> > 
> > Do you actually have the hardware or was this just a code audit?
> > 
> > I have the strong suspicion that this driver is pretty much dead and
> > bitrotting.
> 
> There are a pile of scsi drivers like the Ultrastor that probably want
> retiring via staging.

OK, can someone work out how we do this and then send the patch (I
assume it's just an update in the deprecated features and a move to
staging?)

> I can believe an AHA152x or two lurk around,

Yes, got one ... and occasionally even test with it.

>  and the odd NCR53c80 and
> clones because they were so voluminous but the rest I doubt somewhat.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/