linux-kernel - Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110525124227.GQ14556@legolas.emea.dhcp.ti.com>
Date:	Wed, 25 May 2011 15:42:28 +0300
From:	Felipe Balbi <balbi@...com>
To:	Tanya Brokhman <tlinder@...eaurora.org>
Cc:	balbi@...com, 'Alan Stern' <stern@...land.harvard.edu>,
	'Sarah Sharp' <sarah.a.sharp@...ux.intel.com>, greg@...ah.com,
	linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	ablay@...eaurora.org, 'open list' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

Hi,

On Wed, May 25, 2011 at 02:33:18PM +0300, Tanya Brokhman wrote:
> Ok so just to make sure I understand you correctly:
> You want me to remove the modification made to usb_composite_probe() and
> instead add:
> static struct usb_gadget_driver composite_driver = {
> +#ifdef CONFIG_USB_GADGET_SUPERSPEED
> +       .speed          = USB_SPEE_SUPER,
> +#else
> 	  .speed          = USB_SPEED_HIGH,
> +#endif
> 	  .unbind         = composite_unbind,
> 
> And then you'll be ok with change? Or is there anything else?
> 
> If this is it then I'm relieved :) and of course will update the code.

yeah, that's all. Just be sure not to introduce the typo I introduced
(missed D in SPEED) :-)

Then I'll hold on to those patches for 2.6.41 merge window.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)