linux-kernel - Re: SLUB regression in current Linus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1306338341.2820.28.camel@edumazet-laptop>
Date:	Wed, 25 May 2011 17:45:41 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	James Morris <jmorris@...ei.org>,
	Pekka Enberg <penberg@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: SLUB regression in current Linus

Le mercredi 25 mai 2011 à 10:04 -0500, Christoph Lameter a écrit :
> On Wed, 25 May 2011, Linus Torvalds wrote:
> 
> > On Wed, May 25, 2011 at 7:47 AM, Christoph Lameter <cl@...ux.com> wrote:
> > >
> > > So simply return the object. In the debug case we do not need all the other
> > > processing that unlock_out: does.
> >
> > So that patch looks like it should explain things.
> >
> > But exactly why don't we need the ->tid update and the ALLOC_SLOWPATH
> > stats? Both of them would seem to be equally valid for the debug case.
> 
> We always fall back to the slow path in the debug case. So the tid update
> is useless.

tid change is updated anyway at the end of deactivate_slab()


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/