linux-kernel - Re: SLUB regression in current Linus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1105251129300.26118@router.home>
Date:	Wed, 25 May 2011 11:29:53 -0500 (CDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	James Morris <jmorris@...ei.org>,
	Pekka Enberg <penberg@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: SLUB regression in current Linus

On Wed, 25 May 2011, Eric Dumazet wrote:

> > Index: linux-2.6/mm/slub.c
> > ===================================================================
> > --- linux-2.6.orig/mm/slub.c	2011-05-25 09:41:27.000000000 -0500
> > +++ linux-2.6/mm/slub.c	2011-05-25 09:41:39.000000000 -0500
> > @@ -1884,7 +1884,8 @@ debug:
> >  	deactivate_slab(s, c);
> >  	c->page = NULL;
>
> is this c->page = NULL; really necessary ?

No. deactivate_slab() already sets it to NULL.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/