linux-kernel - Re: [PATCH] usb-gadget: unlock data->lock mutex on error path in ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DDE249D.9000000@ru.mvista.com>
Date:	Thu, 26 May 2011 13:59:57 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
CC:	Greg KH <greg@...ah.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb-gadget: unlock data->lock mutex on error path in
 ep_write()

Hello.

On 26-05-2011 10:32, Alexey Khoroshilov wrote:

> ep_write() acquires data->lock mutex in get_ready_ep() and releases it on
> all paths except for one: when usb_endpoint_xfer_isoc() failed. The
> patch adds mutex_unlock(&data->lock) at that path.

> It is similar to commit 00cc7a5faf25b3ba5cf30fcffc62249bdd152006 for ep_read(),

    Please specify that commit's summary in parens.

> it was not fixed at that time by accident.

> Found by Linux Driver Verification project (linuxtesting.org).

> Signed-off-by: Alexey Khoroshilov<khoroshilov@...ras.ru>

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/