linux-kernel - Re: pch_gpio: Support new device ML7223

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110527065824.GD31271@ponder.secretlab.ca>
Date:	Fri, 27 May 2011 00:58:24 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Alexander Stein <alexander.stein@...tec-electronic.com>
Cc:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, toshiharu-linux@....okisemi.com,
	"'Fan, Yongning'" <yongning.fan@...el.com>
Subject: Re: pch_gpio: Support new device ML7223

On Thu, May 26, 2011 at 08:09:15AM +0200, Alexander Stein wrote:
> On Thursday 26 May 2011 03:24:55 Tomoya MORINAGA wrote:
> > > From: Alexander Stein [mailto:alexander.stein@...tec-electronic.com]
> > > Sent: Wednesday, May 25, 2011 9:10 PM
> > > 
> > > > #define pch_gpio_resume NULL  #endif
> > > > 
> > > > +#define PCI_VENDOR_ID_ROHM             0x10DB
> > > 
> > > Should this be moved to pci_ids.h?
> > 
> > OK.
> > I will move this to pci_ids.h.
> > 
> > > >  static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = {
> > > >  
> > > >  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
> > > > 
> > > > +	{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
> > > 
> > > Likewise for the product ID. While at it, the ID for EG20T
> > > could also be moved in a separate patch.
> > 
> > We have already upstreamed not only GPIO but also many device drivers(GBE,
> > USBDEV,DMA,UART,SPI,I2C,CAN). Do you mean we must move these device
> > definitions to pci_ids.h?
> 
> I just meant to move 0x8803 from the line above into pci_ids.h. It is 
> unrelated to your patch.
> And if this _must_ be moved to pci_ids.h I'm the wrong person to decide.

The top comment block in pci_ids.h says: "Do not add new entries to
this file unless the definitions are shared between multiple drivers"

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/