[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110527070913.GB31953@ponder.secretlab.ca>
Date: Fri, 27 May 2011 01:09:13 -0600
From: Grant Likely <grant.likely@...retlab.ca>
To: Tomoya MORINAGA <tomoya-linux@....okisemi.com>
Cc: linux-kernel@...r.kernel.org, qi.wang@...el.com,
yong.y.wang@...el.com, joel.clark@...el.com,
kok.howg.ewe@...el.com, toshiharu-linux@....okisemi.com
Subject: Re: [PATCH] pch_gpio: Support new device ML7223
On Mon, May 09, 2011 at 07:58:49PM +0900, Tomoya MORINAGA wrote:
> Support new device OKI SEMICONDUCTOR ML7223 IOH(Input/Output Hub).
> The ML7223 IOH is for MP(Media Phone) use.
> The ML7223 is companion chip for Intel Atom E6xx series.
> The ML7223 is completely compatible for Intel EG20T PCH.
>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@....okisemi.com>
I merged this version. Since the device ids are local only to this
driver, there is no need to add them to pci_ids.h
Thanks,
g.
> ---
> drivers/gpio/Kconfig | 8 +++++++-
> drivers/gpio/pch_gpio.c | 2 ++
> 2 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index d3b2953..c0326da 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -329,13 +329,19 @@ config GPIO_LANGWELL
> Say Y here to support Intel Langwell/Penwell GPIO.
>
> config GPIO_PCH
> - tristate "PCH GPIO of Intel Topcliff"
> + tristate "Intel EG20T PCH / OKI SEMICONDUCTOR ML7223 IOH GPIO"
> depends on PCI && X86
> help
> This driver is for PCH(Platform controller Hub) GPIO of Intel Topcliff
> which is an IOH(Input/Output Hub) for x86 embedded processor.
> This driver can access PCH GPIO device.
>
> + This driver also can be used for OKI SEMICONDUCTOR IOH(Input/
> + Output Hub), ML7223.
> + ML7223 IOH is for MP(Media Phone) use.
> + ML7223 is companion chip for Intel Atom E6xx series.
> + ML7223 is completely compatible for Intel EG20T PCH.
> +
> config GPIO_ML_IOH
> tristate "OKI SEMICONDUCTOR ML7213 IOH GPIO support"
> depends on PCI
> diff --git a/drivers/gpio/pch_gpio.c b/drivers/gpio/pch_gpio.c
> index f970a5f..36919e7 100644
> --- a/drivers/gpio/pch_gpio.c
> +++ b/drivers/gpio/pch_gpio.c
> @@ -283,8 +283,10 @@ static int pch_gpio_resume(struct pci_dev *pdev)
> #define pch_gpio_resume NULL
> #endif
>
> +#define PCI_VENDOR_ID_ROHM 0x10DB
> static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
> + { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
> { 0, }
> };
> MODULE_DEVICE_TABLE(pci, pch_gpio_pcidev_id);
> --
> 1.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists