| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4DDFD958.9090700@zytor.com> Date: Fri, 27 May 2011 10:03:20 -0700 From: "H. Peter Anvin" <hpa@...or.com> To: mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...e.hu CC: linux-tip-commits@...r.kernel.org Subject: Re: [tip:x86/urgent] x86, asm: Clean up desc.h a bit On 05/27/2011 01:39 AM, tip-bot for Ingo Molnar wrote: > Commit-ID: 9a3865b185e77d1a4ca2d8356e37c19b78168961 > Gitweb: http://git.kernel.org/tip/9a3865b185e77d1a4ca2d8356e37c19b78168961 > Author: Ingo Molnar <mingo@...e.hu> > AuthorDate: Fri, 27 May 2011 09:29:32 +0200 > Committer: Ingo Molnar <mingo@...e.hu> > CommitDate: Fri, 27 May 2011 09:30:50 +0200 > > x86, asm: Clean up desc.h a bit > > I have looked at this file and found it rather ugly - improve > readability a bit. No change in functionality. > It sure is, but let me also register for the record that I hate the bloody bitfield. A lot of what the bitfield does is completely pointless (breaking down the type field, which really is nothing other than a magic constant as far as the kernel is anyway) and generates insanely bad code. I honestly think if we used macros like GDT_ENTRY() and perhaps a few variants we would make the code simpler. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists