linux-kernel - Re: [Kgdb-bugreport] [PATCH] kgdbts: only use new asm-generic/ptrace.h api when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DE3688A.4040600@mvista.com>
Date:	Mon, 30 May 2011 13:51:06 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Mike Frysinger <vapier@...too.org>
CC:	kgdb-bugreport@...ts.sourceforge.net,
	Jason Wessel <jason.wessel@...driver.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Kgdb-bugreport] [PATCH] kgdbts: only use new asm-generic/ptrace.h
 api when needed

Hello.

On 28-05-2011 18:04, Mike Frysinger wrote:

> The new instruction_pointer_set helper is defined for people who have
> converted to asm-generic/ptrace.h, so don't use it generally unless
> the arch needs it (in which case it has been converted).  This should
> fix building of kgdb tests for arches not yet converted.

> Signed-off-by: Mike Frysinger<vapier@...too.org>
> ---
>   drivers/misc/kgdbts.c |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)

> diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c
> index b0c5631..8cebec5 100644
> --- a/drivers/misc/kgdbts.c
> +++ b/drivers/misc/kgdbts.c
> @@ -304,7 +304,10 @@ static int check_and_rewind_pc(char *put_str, char *arg)
>   		return 1;
>   	}
>   	/* Readjust the instruction pointer if needed */
> -	instruction_pointer_set(&kgdbts_regs, ip + offset);
> +	ip += offset;

    Since 'íp' is local, incrementing it is pointless here unless you have 
GDB_ADJUSTS_BREAK_OFFSET defined. Why not keep instruction_pointer_set() call 
as is?

> +#ifdef GDB_ADJUSTS_BREAK_OFFSET
> +	instruction_pointer_set(&kgdbts_regs, ip);
> +#endif
>   	return 0;
>   }
>

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/