lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <13206.1306779099@turing-police.cc.vt.edu>
Date:	Mon, 30 May 2011 14:11:39 -0400
From:	Valdis.Kletnieks@...edu
To:	Rohit Yadav <rohityadav89@...il.com>
Cc:	len.brown@...el.com, trenn@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Arch: x86: process: Fix a compilation warning.

On Mon, 30 May 2011 23:28:47 +0530, Rohit Yadav said:

> Attached: New patch.

Still needs help:

> Remove unknown escape sequence \i in idle_setup.

> -		WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
> +		WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012.\n");

Changelog should say "Fix mismatched escaped quotes to resolve compiler warning" or
similar. You should explain *what* the patch does (fix the quotes) and *why*
(because it's broken and won't compile).


Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ