linux-kernel - Re: [PATCH] Arch: x86: process: Fix a compilation warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110530182221.GA16214@gere.osrc.amd.com>
Date:	Mon, 30 May 2011 20:22:21 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Valdis.Kletnieks@...edu
Cc:	Rohit Yadav <rohityadav89@...il.com>, len.brown@...el.com,
	trenn@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Arch: x86: process: Fix a compilation warning.

On Mon, May 30, 2011 at 02:11:39PM -0400, Valdis.Kletnieks@...edu wrote:
> On Mon, 30 May 2011 23:28:47 +0530, Rohit Yadav said:
> 
> > Attached: New patch.
> 
> Still needs help:
> 
> > Remove unknown escape sequence \i in idle_setup.
> 
> > -		WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
> > +		WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012.\n");
> 
> Changelog should say "Fix mismatched escaped quotes to resolve compiler warning" or
> similar. You should explain *what* the patch does (fix the quotes) and *why*
> (because it's broken and won't compile).

Yep, all valid points. Another one would be to search whether this got
already fixed before wasting effort:

http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580

But it's not like there's nothing else that needs fixing in Linux. I'd
suggest using the new 'make W=' (do 'make help' for more info) build
option to build single objects and have gcc do more extensive checks.
Some of them actually are valid and need fixing.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/