linux-kernel - Re: [PATCH] ptrace: unify show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110530190713.GA20616@redhat.com>
Date:	Mon, 30 May 2011 21:07:13 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH] ptrace: unify show_regs() prototype

On 05/29, Mike Frysinger wrote:
>
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
> andrew: can you pick this up ?  sent a few months ago w/no love.

The patch looks obviously fine, I can put it into ptrace tree.

Cough. Yes it is simple, but perhaps it still needs the changelog?
Even a single line.

One nit,

> --- a/include/linux/ptrace.h
> +++ b/include/linux/ptrace.h
> @@ -100,6 +100,7 @@
>  #include <linux/sched.h>		/* For struct task_struct.  */
>
>
> +extern void show_regs(struct pt_regs *);

Not sure ptrace.h is the right place. show_regs() has the callers which
have nothing to do with ptrace.

Hmm. You know what? show_regs() is already defined in sched.h, probably
you can simply remove this chunk.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/