linux-kernel - Re: [PATCH] ptrace: unify show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 30 May 2011 18:54:04 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH] ptrace: unify show_regs() prototype

On Mon, May 30, 2011 at 15:07, Oleg Nesterov wrote:
> On 05/29, Mike Frysinger wrote:
>> --- a/include/linux/ptrace.h
>> +++ b/include/linux/ptrace.h
>> +extern void show_regs(struct pt_regs *);
>
> Not sure ptrace.h is the right place. show_regs() has the callers which
> have nothing to do with ptrace.

it needs pt_regs and everyone puts it in their own ptrace.h, so
linux/ptrace.h was the logical common place for it

> Hmm. You know what? show_regs() is already defined in sched.h, probably
> you can simply remove this chunk.

nice, i hadnt noticed.  i'll send a new version.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/