linux-kernel - Re: gpio: gpio-exynos4 build fails in mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110530055424.GB23517@ponder.secretlab.ca>
Date:	Sun, 29 May 2011 23:54:24 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Kyungmin Park <kmpark@...radead.org>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: gpio: gpio-exynos4 build fails in mainline

On Mon, May 30, 2011 at 10:24:47AM +0900, Kyungmin Park wrote:
> On Mon, May 30, 2011 at 12:44 AM, Randy Dunlap <rdunlap@...otime.net> wrote:
> > On Sun, 29 May 2011 08:40:00 -0700 Randy Dunlap wrote:
> >
> >> On Sun, 29 May 2011 08:35:20 -0700 Randy Dunlap wrote:
> >>
> >> > On Sun, 29 May 2011 08:30:32 -0700 Randy Dunlap wrote:
> >> >
> >> > > probably should depend on ARM or some ARM sub-arch/mach-type?
> >> > >
> >> > >
> >> > > drivers/gpio/gpio-exynos4.c:18:11: error: unable to open 'mach/map.h'
> >> > >
> >> > >
> >> > > on x86_64
> >> > >
> >> > > ---
> >> >
> >> > similarly:
> >> >
> >> > drivers/gpio/gpio-plat-samsung.c:22:11: error: unable to open 'plat/gpio-core.h'
> >>
> >>
> >> and
> >>
> >> drivers/gpio/gpio-s5pc100.c:21:11: error: unable to open 'mach/map.h'
> >>
> >>
> >> (this began as x86_64 allmodconfig)
> >
> > and
> >
> > drivers/gpio/gpio-s5pv210.c:17:11: error: unable to open 'plat/gpio-core.h'
> 
> Hi,
> 
> Right, now it's just moved from mach directories to drivers/gpio
> So it requires the proper depends on each ARCH_CPU.
> 
> Thank you,
> Kyungmin Park

A variant on this patch merged and pushed out to the following branch.  Thanks.

git://git.secretlab.ca/git/linux-2.6 gpio/merge

It should be in linux-next tomorrow.

g.

> ---
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5923976..655babf 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -88,24 +88,28 @@ config GPIO_IT8761E
> 
>  config GPIO_EXYNOS4
>         bool "Samsung Exynos4 GPIO library support"
> +       depends on CPU_EXYNOS4210
>         default y if CPU_EXYNOS4210
>         help
>           Say yes here to support Samsung Exynos4 series SoCs GPIO library
> 
>  config GPIO_PLAT_SAMSUNG
>         bool "Samsung SoCs GPIO library support"
> +       depends on SAMSUNG_GPIOLIB_4BIT
>         default y if SAMSUNG_GPIOLIB_4BIT
>         help
>           Say yes here to support Samsung SoCs GPIO library
> 
>  config GPIO_S5PC100
>         bool "Samsung S5PC100 GPIO library support"
> +       depends on CPU_S5PC100
>         default y if CPU_S5PC100
>         help
>           Say yes here to support Samsung S5PC100 SoCs GPIO library
> 
>  config GPIO_S5PV210
>         bool "Samsung S5PV210/S5PC110 GPIO library support"
> +       depends on CPU_S5PV210
>         default y if CPU_S5PV210
>         help
>           Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> 
> >
> >
> > ---
> > ~Randy
> > *** Remember to use Documentation/SubmitChecklist when testing your code ***
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/