linux-kernel - Re: [PATCH v3] 8250_pci: add -ENODEV code for Intel EG20T PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110531084052.GA13972@rere.qmqm.pl>
Date:	Tue, 31 May 2011 10:40:53 +0200
From:	Michał Mirosław <mirq@...e.qmqm.pl>
To:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>
Cc:	Alan Cox <alan@...ux.intel.com>, gregkh@...e.de,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, toshiharu-linux@....okisemi.com
Subject: Re: [PATCH v3] 8250_pci: add -ENODEV code for Intel EG20T PCH

On Tue, May 31, 2011 at 11:22:39AM +0900, Tomoya MORINAGA wrote:
> Intel EG20T PCH has UART device which is compatible with 8250.
> Currently, with general configuration, the PCH UART driver is not loaded but
> 8250 standard driver is loaded.
> Therefore, in case of using PCH UART driver, need to disable 8250 pci function.
> However, this procedure is not best solution.
> This patch, in 8250_pci, if the device is the PCH or the family IOH,
> '-ENODEV' is returned.
> As a result, disabling 8250-pci processing becomes unnecessary.
[...]
> +static int pci_eg20tpch_init(struct pci_dev *dev)
> +{
> +	return -ENODEV;
> +}

You could name it just return_ENODEV() or similar and then while looking
at the device-id table you would know right away what this entry is doing.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/