linux-kernel - Re: [PATCH v3] 8250_pci: add -ENODEV code for Intel EG20T PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110531100959.011ea462@bob.linux.org.uk>
Date:	Tue, 31 May 2011 10:09:59 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, toshiharu-linux@....okisemi.com
Subject: Re: [PATCH v3] 8250_pci: add -ENODEV code for Intel EG20T PCH

> V2: Delete #ifdef CONFIG_SERIAL_PCH_UART ~ #endif
>     Use quirk table structure

I would keep the ifdef. We want to fall back and if we don't do that
then users currently using 8250 will have their system break on upgrade
which is not acceptable really.

So I'd keep with the patch below but:

> +static int pci_eg20tpch_init(struct pci_dev *dev)
> +{
#if !defined(CONFIG_SERIAL_PCH_UART) && ...
> +	return -ENODEV;
#else
	return 0;
#endif

> +}


I don't think we can avoid that one ifdef without breakage.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/